Set generic type of SimpleCookie #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyright complains about `response.cookies` because the generic type isn't known. `str` may or may not be the correct type to use here. Something should be set here.
sobolevn
reviewed
Jun 23, 2022
| @@ -17,7 +17,7 @@ class ContentNotRenderedError(Exception): ... | |||
| class SimpleTemplateResponse(HttpResponse): | |||
| content: Any = ... | |||
| closed: bool | |||
| cookies: SimpleCookie | |||
| cookies: SimpleCookie[str] | |||
There was a problem hiding this comment.
Or bytes? Can you please double check that?
There was a problem hiding this comment.
I think it's meant to be str.
I also just noticed there are other instances of SimpleCookie in the codebase without type parameterts, such as in test/client.pyi. Maybe someone more familiar with cookies will come along and fix these types.
There was a problem hiding this comment.
Yes, it is str as per docs: https://docs.djangoproject.com/en/4.0/ref/request-response/#django.http.HttpRequest.COOKIES
sobolevn
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyright complains about
response.cookiesbecause the generic type isn't known.strmay or may not be the correct type to use here. Something should be set here.Related issues
There are no related issues. I just saw this in my editor and wanted to point it out here.